Re: [PATCH bpf] xsk: fix a documentation mistake in xsk_queue.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 28, 2020 at 10:49 AM Ciara Loftus <ciara.loftus@xxxxxxxxx> wrote:
>
> After 'peeking' the ring, the consumer, not the producer, reads the data.
> Fix this mistake in the comments.
>
> Fixes: 15d8c9162ced ("xsk: Add function naming comments and reorder functions")
> Signed-off-by: Ciara Loftus <ciara.loftus@xxxxxxxxx>
> ---
>  net/xdp/xsk_queue.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/xdp/xsk_queue.h b/net/xdp/xsk_queue.h
> index bf42cfd74b89..a0bb2f722b3f 100644
> --- a/net/xdp/xsk_queue.h
> +++ b/net/xdp/xsk_queue.h
> @@ -96,7 +96,7 @@ struct xsk_queue {
>   * seen and read by the consumer.
>   *
>   * The consumer peeks into the ring to see if the producer has written
> - * any new entries. If so, the producer can then read these entries
> + * any new entries. If so, the consumer can then read these entries
>   * and when it is done reading them release them back to the producer
>   * so that the producer can use these slots to fill in new entries.
>   *
> --
> 2.17.1
>

Thank you Ciara.

Acked-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx>



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux