On 9/25/20 4:46 PM, Jakub Kicinski wrote:
On Thu, 24 Sep 2020 20:21:22 +0200 Daniel Borkmann wrote:Similarly to 5a52ae4e32a6 ("bpf: Allow to retrieve cgroup v1 classid from v2 hooks"), add a helper to retrieve cgroup v1 classid solely based on the skb->sk, so it can be used as key as part of BPF map lookups out of tc from host ns, in particular given the skb->sk is retained these days when crossing net ns thanks to 9c4c325252c5 ("skbuff: preserve sock reference when scrubbing the skb."). This is similar to bpf_skb_cgroup_id() which implements the same for v2. Kubernetes ecosystem is still operating on v1 however, hence net_cls needs to be used there until this can be dropped in with the v2 helper of bpf_skb_cgroup_id(). Signed-off-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx>FWIW lot's of whitespace warnings from checkpatch --strict about comments having spaces before tabs here.
Expected given the way the UAPI helper comment is formatted / done in order to then render the man page. So it's formatted the same way as the other helper descriptions. Thanks, Daniel
