Re: [PATCH bpf-next 2/3] selftests/bpf: Fix endianness issues in sk_lookup/ctx_narrow_access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 23, 2020 at 11:12 PM CEST, Ilya Leoshkevich wrote:
> On Thu, 2020-09-10 at 09:55 -0700, Andrii Nakryiko wrote:
>> On Wed, Sep 9, 2020 at 6:59 PM Ilya Leoshkevich <iii@xxxxxxxxxxxxx>
>> wrote:
>> > This test makes a lot of narrow load checks while assuming little
>> > endian architecture, and therefore fails on s390.
>> > 
>> > Fix by introducing LSB and LSW macros and using them to perform
>> > narrow
>> > loads.
>> > 
>> > Fixes: 0ab5539f8584 ("selftests/bpf: Tests for BPF_SK_LOOKUP attach
>> > point")
>> > Signed-off-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx>
>> > ---
>> 
>> Jakub,
>> 
>> Can you please help review this to make sure no error accidentally
>> slipped in?
>
> Gentle ping.

Sorry for being unresponsive. I've been off for a couple of weeks.

I'm on it.

[...]



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux