Re: [PATCH bpf-next v8 11/11] selftests: Remove fmod_ret from benchmarks and test_overhead

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 22, 2020 at 11:39 AM Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote:
>
> From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
>
> The benchmark code and the test_overhead prog_test included fmod_ret
> programs that attached to various functions in the kernel. However, these
> functions were never listed as allowed for return modification, so this
> only worked because of the verifier skipping tests when a trampoline
> already existed for the attach point. Now that the verifier checks have
> been fixed, remove fmod_ret from the affected tests so they all work again.
>
> Fixes: 4eaf0b5c5e04 ("selftest/bpf: Fmod_ret prog and implement test_overhead as part of bench")
> Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
> ---

Acked-by: Andrii Nakryiko <andriin@xxxxxx>

>  tools/testing/selftests/bpf/bench.c                |    5 -----
>  tools/testing/selftests/bpf/benchs/bench_rename.c  |   17 -----------------
>  tools/testing/selftests/bpf/benchs/bench_trigger.c |   17 -----------------
>  .../selftests/bpf/prog_tests/test_overhead.c       |   14 +-------------
>  tools/testing/selftests/bpf/progs/test_overhead.c  |    6 ------
>  tools/testing/selftests/bpf/progs/trigger_bench.c  |    7 -------
>  6 files changed, 1 insertion(+), 65 deletions(-)
>

[...]




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux