Re: [PATCH RFC bpf-next 5/5] bpf: Do not include the original insn in zext patchlet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Alexei!

>>>>> On Thu, 10 Sep 2020 17:25:43 -0700, Alexei Starovoitov  wrote:

 > On Wed, Sep 9, 2020 at 4:37 PM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote:
 >> 
 >> If the original insn is a jump, then it is not subjected to branch
 >> adjustment, which is incorrect. As discovered by Yauheni in

 > I think the problem is elsewhere.
 > Something is wrong with zext logic.
 > the branch insn should not have been marked as zext_dst.
 > and in the line:
 > zext_patch[0] = insn;
 > this 'insn' should never be a branch.
 > See insn_no_def().

Yes, it may be the case, as I mentioned in my analysis, but the
patching itself looks much more clear with Ilya's changes.

-- 
WBR,
Yauheni Kaliuta




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux