On Thu, 10 Sep 2020 at 19:18, Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Wed, Sep 9, 2020 at 9:25 AM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote: > > > > The "SEE ALSO" sections of bpftool's manual pages refer to bpf(2), > > bpf-helpers(7), then all existing bpftool man pages (save the current > > one). > > > > This leads to nearly-identical lists being duplicated in all manual > > pages. Ideally, when a new page is created, all lists should be updated > > accordingly, but this has led to omissions and inconsistencies multiple > > times in the past. > > > > Let's take it out of the RST files and generate the "SEE ALSO" sections > > automatically in the Makefile when generating the man pages. The lists > > are not really useful in the RST anyway because all other pages are > > available in the same directory. > > > > v2: > > - Use "echo -n" instead of "printf" in Makefile, to avoid any risk of > > passing a format string directly to the command. > > > > Signed-off-by: Quentin Monnet <quentin@xxxxxxxxxxxxx> > > Acked-by: Andrii Nakryiko <andriin@xxxxxx> > > This patch failed to git am, but I've applied the first two patches. > Thanks Right, there is a conflict with the other patchset passing $(RST2MAN_OPTS) to rst2man when building the doc. I'll rebase and repost this one. Thank you Alexei. Quentin
