On Wed, Sep 9, 2020 at 6:59 PM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote:
>
> server_map's value size is 8, but the test tries to put an int there.
> This sort of works on x86 (unless followed by non-0), but hard fails on
> s390.
>
> Fix by using long instead of int.
>
> Fixes: 2d7824ffd25c ("selftests: bpf: Add test for sk_assign")
> Signed-off-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx>
> ---
> tools/testing/selftests/bpf/prog_tests/sk_assign.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/sk_assign.c b/tools/testing/selftests/bpf/prog_tests/sk_assign.c
> index a49a26f95a8b..402d0da8e05a 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sk_assign.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sk_assign.c
> @@ -265,7 +265,7 @@ void test_sk_assign(void)
> TEST("ipv6 udp port redir", AF_INET6, SOCK_DGRAM, false),
> TEST("ipv6 udp addr redir", AF_INET6, SOCK_DGRAM, true),
> };
> - int server = -1;
> + long server = -1;
this would still fail on 32-bit arches, so maybe __s64 instead?
> int server_map;
> int self_net;
> int i;
> --
> 2.25.4
>
