On Tue, 8 Sep 2020 13:32:01 +0300 Maxim Mikityanskiy <maximmi@xxxxxxxxxx> wrote: > From the driver API perspective, I would prefer to see a simpler API if > possible. The current API exposes things that the driver shouldn't know > (BPF map type), and requires XSK-specific handling. It would be better > if some specific error code returned from xdp_do_redirect was reserved > to mean "exit NAPI early if you support it". This way we wouldn't need > two new helpers, two xdp_do_redirect functions, and this approach would > be extensible to other non-XSK use cases without further changes in the > driver, and also the logic to opt-in the feature could be put inside the > kernel. I agree. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
