On Wed, 9 Sep 2020 at 07:17, Martin KaFai Lau <kafai@xxxxxx> wrote: > > I skimmed through the set. Patch 5 to 11 are useful. It is a nice refactoring > and clean up. Thanks for the work. I like the idea of moving out the logic > after "if (!type_is_sk_pointer(type)) goto err_type;" and moving the null > register check to the beginning. Thanks! > I don't think this set should depend on the sockmap iter set. > I think the sockmap iter patches should depend on this set instead. > For example, the changes in patch 1 of the sockmap iter patchset that > moves out the "btf_struct_ids_match()" logic after the > "if (!type_is_sk_pointer(type)) goto err_type;" should belong to this set. That's what I did in the beginning. However this is a much bigger change to land than sockmap iter, and I anticipate that review will take longer. Which means it will delay the patchset that I actually need. Hence my preference to do it this way round, with the minimal changes necessary in sockmap iter. -- Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com
