Re: [PATCH bpf-next 0/2] bpf: detect build errors for man pages for bpftool and eBPF helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 7, 2020 at 9:40 AM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote:
>
> This set aims at improving the checks for building bpftool's documentation
> (including the man page for eBPF helper functions). The first patch lowers
> the log-level from rst2man and fix the reported informational messages. The
> second one extends the script used to build bpftool in the eBPF selftests,
> so that we also check a documentation build.
>
> This is after a suggestion from Andrii Nakryiko.
>
> Quentin Monnet (2):
>   tools: bpftool: log info-level messages when building bpftool man
>     pages
>   selftests, bpftool: add bpftool (and eBPF helpers) documentation build
>
>  tools/bpf/bpftool/Documentation/Makefile      |  2 +-
>  .../bpf/bpftool/Documentation/bpftool-btf.rst |  3 +++
>  .../bpf/bpftool/Documentation/bpftool-gen.rst |  4 ++++
>  .../bpf/bpftool/Documentation/bpftool-map.rst |  3 +++
>  .../selftests/bpf/test_bpftool_build.sh       | 23 +++++++++++++++++++
>  5 files changed, 34 insertions(+), 1 deletion(-)
>
> --
> 2.25.1
>

LGTM.

Acked-by: Andrii Nakryiko <andriin@xxxxxx>

But this still won't be run every time someone makes selftests. We do
build bpftool during selftests build, so it would be good to run doc
build there as well to ensure everyone is executing this. But this is
a good first step for sure.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux