On Wed, Aug 26, 2020 at 3:19 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
>
> Alexei reported compile breakage on newer systems with
> following error:
>
> In file included from /usr/include/fcntl.h:290:0,
> 4814 from ./test_progs.h:29,
> 4815 from
> .../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:3:
> 4816In function ‘open’,
> 4817 inlined from ‘trigger_fstat_events’ at
> .../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:50:10,
> 4818 inlined from ‘test_d_path’ at
> .../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:119:6:
> 4819/usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:4: error: call to
> ‘__open_missing_mode’ declared with attribute error: open with O_CREAT
> or O_TMPFILE in second argument needs 3 arguments
> 4820 __open_missing_mode ();
> 4821 ^~~~~~~~~~~~~~~~~~~~~~
>
> We're missing permission bits as 3rd argument
> for open call with O_CREAT flag specified.
>
> Reported-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> Fixes: e4d1af4b16f8 ("selftests/bpf: Add test for d_path helper")
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
Applied. Thanks
