Re: [PATCH bpf] selftests/bpf: Fix test_progs-flavor run getting number of tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 21 Aug 2020 12:45:08 -0700
Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote:

> > diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
> > index b1e4dadacd9b..d858e883bd75 100644
> > --- a/tools/testing/selftests/bpf/test_progs.c
> > +++ b/tools/testing/selftests/bpf/test_progs.c
> > @@ -618,7 +618,7 @@ int cd_flavor_subdir(const char *exec_name)
> >         if (!flavor)
> >                 return 0;
> >         flavor++;
> > -       fprintf(stdout, "Switching to flavor '%s' subdirectory...\n", flavor);
> > +       fprintf(stderr, "Switching to flavor '%s' subdirectory...\n", flavor);  
> 
> Hmm. May be move it under -v flag instead?
> The person or script that runs test_progs-no_alu32 knows what's happening.
> That message either to stdout or stderr will be fine under extra verbose flag.

Sounds good to me with a -v flag, sending V2

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux