On Tue, Aug 18, 2020 at 6:25 PM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Tue, Aug 18, 2020 at 6:24 PM Andrii Nakryiko <andriin@xxxxxx> wrote: > > > > Get rid of two feature detectors: reallocarray and libelf-mmap. Optional > > feature detections complicate libbpf Makefile and cause more troubles for > > various applications that want to integrate libbpf as part of their build. > > > > Patch #1 replaces all reallocarray() uses into libbpf-internal reallocarray() > > implementation. Patches #2 and #3 makes sure we won't re-introduce > > reallocarray() accidentally. Patch #2 also removes last use of > > libbpf_internal.h header inside bpftool. There is still nlattr.h that's used > > by both libbpf and bpftool, but that's left for a follow up patch to split. > > Patch #4 removed libelf-mmap feature detector and all its uses, as it's > > trivial to handle missing mmap support in libbpf, the way objtool has been > > doing it for a while. > > > > v1->v2: > > - rebase to latest bpf-next (Alexei). > > still no good. pls rebase again. can't keep up :) rebasing