Re: [PATCH 12/17] proc/fd: In fdinfo seq_show don't use get_files_struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 12/17] proc/fd: In fdinfo seq_show don't use get_files_struct
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 17 Aug 2020 18:21:07 -0700
Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, "<linux-fsdevel@xxxxxxxxxxxxxxx>" <linux-fsdevel@xxxxxxxxxxxxxxx>, criu@xxxxxxxxxx, bpf <bpf@xxxxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <christian.brauner@xxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Cyrill Gorcunov <gorcunov@xxxxxxxxx>, Jann Horn <jann@xxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Matthew Wilcox <matthew@xxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Martin KaFai Lau <kafai@xxxxxx>, Song Liu <songliubraving@xxxxxx>, Yonghong Song <yhs@xxxxxx>, Andrii Nakryiko <andriin@xxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxxxx>
In-reply-to: <87v9hg69ph.fsf@x220.int.ebiederm.org>

On Mon, Aug 17, 2020 at 6:13 PM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> task_lock is needed to protect task->files.

Hah. Right you are. I found a few cases where we didn't do that, but I
hadn't noticed that they were all of the pattern

        struct task_struct *tsk = current;

so "tsk->files" was safe for that reason..

So never mind.

           Linus

References:
- exec: Move unshare_files and guarantee files_struct.count is correct
  - From: Eric W. Biederman
- [PATCH 12/17] proc/fd: In fdinfo seq_show don't use get_files_struct
  - From: Eric W. Biederman
- Re: [PATCH 12/17] proc/fd: In fdinfo seq_show don't use get_files_struct
  - From: Linus Torvalds

Prev by Date: Re: [PATCH bpf-next v8 5/7] bpf: Implement bpf_local_storage for inodes
Next by Date: Re: [PATCH 10/17] proc/fd: In proc_readfd_common use fnext_task
Previous by thread: Re: [PATCH 12/17] proc/fd: In fdinfo seq_show don't use get_files_struct
Next by thread: Re: [PATCH 12/17] proc/fd: In fdinfo seq_show don't use get_files_struct
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]