Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

[linmiaohe <linmiaohe@xxxxxxxxxx>]

Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote:
On Fri, Aug 14, 2020 at 2:58 AM Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
>>
>> Convert the uses of fallthrough comments to fallthrough macro.
>> @@ -1794,7 +1794,7 @@ static bool cg_sockopt_is_valid_access(int off, int size,
>>                         return prog->expected_attach_type ==
>>                                 BPF_CGROUP_GETSOCKOPT;
>>                 case offsetof(struct bpf_sockopt, optname):
>> -                       /* fallthrough */
>> +                       fallthrough;
>
>this fallthrough is not event necessary, let's drop it instead?

Will do. Many thanks.

>
>>                 case offsetof(struct bpf_sockopt, level):
>>                         if (size != size_default)
>>                                 return false;
>
> [...]