RE: [PATCH bpf-next] libbf: fix uninitialized pointer at btf__parse_raw()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Daniel T. Lee wrote:
> Recently, from commit 94a1fedd63ed ("libbpf: Add btf__parse_raw() and
> generic btf__parse() APIs"), new API has been added to libbpf that
> allows to parse BTF from raw data file (btf__parse_raw()).
> 
> The commit derives build failure of samples/bpf due to improper access
> of uninitialized pointer at btf_parse_raw().
> 
>     btf.c: In function btf__parse_raw:
>     btf.c:625:28: error: btf may be used uninitialized in this function
>       625 |  return err ? ERR_PTR(err) : btf;
>           |         ~~~~~~~~~~~~~~~~~~~^~~~~
> 
> This commit fixes the build failure of samples/bpf by adding code of
> initializing btf pointer as NULL.
> 
> Fixes: 94a1fedd63ed ("libbpf: Add btf__parse_raw() and generic btf__parse() APIs")
> Signed-off-by: Daniel T. Lee <danieltimlee@xxxxxxxxx>
> ---

Unless errno is zero this should be ok in practice, but I guess compiler
wont know that.

Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux