On Tue, 2020-07-28 at 13:59 -0700, Song Liu wrote: > On Tue, Jul 28, 2020 at 5:14 AM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> > wrote: > > s390 uses socketcall multiplexer instead of individual socket > > syscalls. > > Therefore, "kprobe/" SYSCALL(sys_connect) does not trigger and > > test_map_in_map fails. Fix by using "kprobe/__sys_connect" instead. > > samples/bpf is in semi-deprecated state. I tried for quite some time, > but still > cannot build it all successfully. So I apologize for bounding the > question to you... > > From the code, we do the SYSCALL() trick to change the exact name for > different architecture. Would this change break the same file for > x86? No, it shouldn't - __sys_connect exists on all architectures and gets control from both regular socket syscalls and socketcall multiplexer. I tested it on x86 and it worked for me. It's also already used by tools/testing/selftests/bpf/progs/test_probe_user.c Best regards, Ilya
