On Fri, 2020-07-10 at 20:18 +0200, Alexander A. Klimov wrote: > > Am 10.07.20 um 18:12 schrieb Toke Høiland-Jørgensen: > > Joe Perches <joe@xxxxxxxxxxx> writes: > > > > > On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote: > > > > On 7/10/20 8:17 AM, Alexander A. Klimov wrote: > > > > > Am 09.07.20 um 22:37 schrieb Daniel Borkmann: > > > > > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote: > > > > > > > Rationale: > > > > > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" > > > > > > > which has nothing to do with XDP. > > > [] > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > [] > > > > > > > @@ -18708,8 +18708,8 @@ F: include/trace/events/xdp.h > > > > > > > F: kernel/bpf/cpumap.c > > > > > > > F: kernel/bpf/devmap.c > > > > > > > F: net/core/xdp.c > > > > > > > -N: xdp > > > > > > > -K: xdp > > > > > > > +N: (?:\b|_)xdp(?:\b|_) > > > > > > > +K: (?:\b|_)xdp(?:\b|_) > > > > > > > > > > > > Please also include \W to generally match on non-alphanumeric char given you > > > > > > explicitly want to avoid [a-z0-9] around the term xdp. > > > > > Aren't \W, ^ and $ already covered by \b? > > > > > > > > Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good. > > > > In case this goes via net or net-next tree: > > > > > > This N: pattern does not match files like: > > > > > > samples/bpf/xdp1_kern.c > > > > > > and does match files like: > > > > > > drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > > > > > > Should it? > > > > I think the idea is that it should match both? > In *your* opinion: Which of these shall it (not) match? Dunno, but it doesn't match these files. The first 5 are good, the rest probably should. $ git ls-files | grep xdp | grep -v -P '(?:\b|_)xdp(?:\b|_)' Documentation/hwmon/xdpe12284.rst arch/arm/mach-ixp4xx/ixdp425-pci.c arch/arm/mach-ixp4xx/ixdp425-setup.c arch/arm/mach-ixp4xx/ixdpg425-pci.c drivers/hwmon/pmbus/xdpe12284.c samples/bpf/xdp1_kern.c samples/bpf/xdp1_user.c samples/bpf/xdp2_kern.c samples/bpf/xdp2skb_meta.sh samples/bpf/xdp2skb_meta_kern.c samples/bpf/xdpsock.h samples/bpf/xdpsock_kern.c samples/bpf/xdpsock_user.c tools/testing/selftests/bpf/progs/xdping_kern.c tools/testing/selftests/bpf/test_xdping.sh tools/testing/selftests/bpf/xdping.c tools/testing/selftests/bpf/xdping.h
