On 09-Jul 12:37, kernel test robot wrote: > Hi KP, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: https://github.com/0day-ci/linux/commits/KP-Singh/Generalizing-bpf_local_storage/20200709-085810 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > config: mips-allyesconfig (attached as .config) > compiler: mips-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > >> kernel/bpf/bpf_inode_storage.c:274:17: warning: no previous prototype for 'inode_storage_map_alloc' [-Wmissing-prototypes] > 274 | struct bpf_map *inode_storage_map_alloc(union bpf_attr *attr) > | ^~~~~~~~~~~~~~~~~~~~~~~ > >> kernel/bpf/bpf_inode_storage.c:286:6: warning: no previous prototype for 'inode_storage_map_free' [-Wmissing-prototypes] > 286 | void inode_storage_map_free(struct bpf_map *map) > | ^~~~~~~~~~~~~~~~~~~~~~ Thanks! Should have been static. Fixed these. Will send a v4 with these fixes. - KP > > vim +/inode_storage_map_alloc +274 kernel/bpf/bpf_inode_storage.c > > 273 > > 274 struct bpf_map *inode_storage_map_alloc(union bpf_attr *attr) > 275 { > 276 struct bpf_local_storage_map *smap; > 277 > 278 smap = bpf_local_storage_map_alloc(attr); > 279 if (IS_ERR(smap)) > 280 return ERR_CAST(smap); > 281 > 282 smap->cache_idx = cache_idx_get_inode(); > 283 return &smap->map; > 284 } > 285 > > 286 void inode_storage_map_free(struct bpf_map *map) > 287 { > 288 struct bpf_local_storage_map *smap; > 289 > 290 smap = (struct bpf_local_storage_map *)map; > 291 cache_idx_free_inode(smap->cache_idx); > 292 bpf_local_storage_map_free(smap); > 293 } > 294 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
