Re: [PATCH bpf-next] bpf: Fix another bpftool segfault without skeleton code enabled

[Daniel Borkmann <daniel@xxxxxxxxxxxxx>]

On 7/8/20 1:08 PM, louis.peens@xxxxxxxxxxxxx wrote:
> From: Louis Peens <louis.peens@xxxxxxxxxxxxx>
>
> emit_obj_refs_json needs to added the same as with emit_obj_refs_plain
> to prevent segfaults, similar to Commit "8ae4121bd89e bpf: Fix bpftool
> without skeleton code enabled"). See the error below:
>
>      # ./bpftool -p prog
>      {
>          "error": "bpftool built without PID iterator support"
>      },[{
>              "id": 2,
>              "type": "cgroup_skb",
>              "tag": "7be49e3934a125ba",
>              "gpl_compatible": true,
>              "loaded_at": 1594052789,
>              "uid": 0,
>              "bytes_xlated": 296,
>              "jited": true,
>              "bytes_jited": 203,
>              "bytes_memlock": 4096,
>              "map_ids": [2,3
>      Segmentation fault (core dumped)
>
> The same happens for ./bpftool -p map, as well as ./bpftool -j prog/map.
>
> Fixes: d53dee3fe013 ("tools/bpftool: Show info for processes holding BPF map/prog/link/btf FDs")
> Signed-off-by: Louis Peens <louis.peens@xxxxxxxxxxxxx>
> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxxx>

Applied, thanks!