On Wed, Jul 8, 2020 at 4:00 AM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Tue, Jul 7, 2020 at 11:49 AM Daniel T. Lee <danieltimlee@xxxxxxxxx> wrote:
> >
> > samples/bpf no longer use bpf_map_def_legacy and instead use the
> > libbpf's bpf_map_def or new BTF-defined MAP format. This commit removes
> > unused bpf_map_def_legacy struct from selftests/bpf/bpf_legacy.h.
> >
> > Signed-off-by: Daniel T. Lee <danieltimlee@xxxxxxxxx>
> > ---
>
> Next time please don't forget to keep Ack's you've received on
> previous revision.
>
I'll keep that in mind.
Thank you for your time and effort for the review.
Daniel.
> > tools/testing/selftests/bpf/bpf_legacy.h | 14 --------------
> > 1 file changed, 14 deletions(-)
> >
> > diff --git a/tools/testing/selftests/bpf/bpf_legacy.h b/tools/testing/selftests/bpf/bpf_legacy.h
> > index 6f8988738bc1..719ab56cdb5d 100644
> > --- a/tools/testing/selftests/bpf/bpf_legacy.h
> > +++ b/tools/testing/selftests/bpf/bpf_legacy.h
> > @@ -2,20 +2,6 @@
> > #ifndef __BPF_LEGACY__
> > #define __BPF_LEGACY__
> >
> > -/*
> > - * legacy bpf_map_def with extra fields supported only by bpf_load(), do not
> > - * use outside of samples/bpf
> > - */
> > -struct bpf_map_def_legacy {
> > - unsigned int type;
> > - unsigned int key_size;
> > - unsigned int value_size;
> > - unsigned int max_entries;
> > - unsigned int map_flags;
> > - unsigned int inner_map_idx;
> > - unsigned int numa_node;
> > -};
> > -
> > #define BPF_ANNOTATE_KV_PAIR(name, type_key, type_val) \
> > struct ____btf_map_##name { \
> > type_key key; \
> > --
> > 2.25.1
> >
