On 2020-07-06 21:39, Daniel Borkmann wrote:
On 7/2/20 2:18 PM, Magnus Karlsson wrote:
This patch set adds support to share a umem between AF_XDP sockets
bound to different queue ids on the same device or even between
devices. It has already been possible to do this by registering the
umem multiple times, but this wastes a lot of memory. Just imagine
having 10 threads each having 10 sockets open sharing a single
umem. This means that you would have to register the umem 100 times
consuming large quantities of memory.
Sounds like this series has some great stuff!
[...]
Note to Maxim at Mellanox. I do not have a mlx5 card, so I have not
been able to test the changes to your driver. It compiles, but that is
all I can say, so it would be great if you could test it. Also, I did
change the name of many functions and variables from umem to pool as a
buffer pool is passed down to the driver in this patch set instead of
the umem. I did not change the name of the files umem.c and
umem.h. Please go through the changes and change things to your
liking.
Bjorn / Maxim, this is waiting on review (& mlx5 testing) from you, ptal.
Sure, I'll take a look and do the mlx5 testing (I only noticed this
series yesterday).
Thanks,
Daniel