Re: [PATCH bpf-next v3 02/16] bpf: Introduce SK_LOOKUP program type with a dedicated attach point

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jakub,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20200702]
[cannot apply to bpf-next/master bpf/master net/master vhost/linux-next ipvs/master net-next/master linus/master v5.8-rc3 v5.8-rc2 v5.8-rc1 v5.8-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jakub-Sitnicki/Run-a-BPF-program-on-socket-lookup/20200702-173127
base:    d37d57041350dff35dd17cbdf9aef4011acada38
config: x86_64-randconfig-s021-20200705 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-3-gfa153962-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)

   net/core/filter.c:402:33: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:405:33: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:408:33: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:411:33: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:414:33: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:488:27: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:491:27: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:494:27: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:1382:39: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct sock_filter const *filter @@     got struct sock_filter [noderef] __user *filter @@
   net/core/filter.c:1382:39: sparse:     expected struct sock_filter const *filter
   net/core/filter.c:1382:39: sparse:     got struct sock_filter [noderef] __user *filter
   net/core/filter.c:1460:39: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct sock_filter const *filter @@     got struct sock_filter [noderef] __user *filter @@
   net/core/filter.c:1460:39: sparse:     expected struct sock_filter const *filter
   net/core/filter.c:1460:39: sparse:     got struct sock_filter [noderef] __user *filter
   net/core/filter.c:7044:27: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:7047:27: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:7050:27: sparse: sparse: subtraction of functions? Share your drugs
   net/core/filter.c:8770:31: sparse: sparse: symbol 'sk_filter_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8777:27: sparse: sparse: symbol 'sk_filter_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8781:31: sparse: sparse: symbol 'tc_cls_act_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8789:27: sparse: sparse: symbol 'tc_cls_act_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8793:31: sparse: sparse: symbol 'xdp_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8804:31: sparse: sparse: symbol 'cg_skb_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8810:27: sparse: sparse: symbol 'cg_skb_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8814:31: sparse: sparse: symbol 'lwt_in_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8820:27: sparse: sparse: symbol 'lwt_in_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8824:31: sparse: sparse: symbol 'lwt_out_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8830:27: sparse: sparse: symbol 'lwt_out_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8834:31: sparse: sparse: symbol 'lwt_xmit_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8841:27: sparse: sparse: symbol 'lwt_xmit_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8845:31: sparse: sparse: symbol 'lwt_seg6local_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8851:27: sparse: sparse: symbol 'lwt_seg6local_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8855:31: sparse: sparse: symbol 'cg_sock_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8861:27: sparse: sparse: symbol 'cg_sock_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8864:31: sparse: sparse: symbol 'cg_sock_addr_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8870:27: sparse: sparse: symbol 'cg_sock_addr_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8873:31: sparse: sparse: symbol 'sock_ops_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8879:27: sparse: sparse: symbol 'sock_ops_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8882:31: sparse: sparse: symbol 'sk_skb_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8889:27: sparse: sparse: symbol 'sk_skb_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8892:31: sparse: sparse: symbol 'sk_msg_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8899:27: sparse: sparse: symbol 'sk_msg_prog_ops' was not declared. Should it be static?
   net/core/filter.c:8902:31: sparse: sparse: symbol 'flow_dissector_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:8908:27: sparse: sparse: symbol 'flow_dissector_prog_ops' was not declared. Should it be static?
   net/core/filter.c:9214:31: sparse: sparse: symbol 'sk_reuseport_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:9220:27: sparse: sparse: symbol 'sk_reuseport_prog_ops' was not declared. Should it be static?
>> net/core/filter.c:9399:27: sparse: sparse: symbol 'sk_lookup_prog_ops' was not declared. Should it be static?
>> net/core/filter.c:9402:31: sparse: sparse: symbol 'sk_lookup_verifier_ops' was not declared. Should it be static?
   net/core/filter.c:217:32: sparse: sparse: cast to restricted __be16
   net/core/filter.c:217:32: sparse: sparse: cast to restricted __be16
   net/core/filter.c:217:32: sparse: sparse: cast to restricted __be16
   net/core/filter.c:217:32: sparse: sparse: cast to restricted __be16
   net/core/filter.c:244:32: sparse: sparse: cast to restricted __be32
   net/core/filter.c:244:32: sparse: sparse: cast to restricted __be32
   net/core/filter.c:244:32: sparse: sparse: cast to restricted __be32
   net/core/filter.c:244:32: sparse: sparse: cast to restricted __be32
   net/core/filter.c:244:32: sparse: sparse: cast to restricted __be32
   net/core/filter.c:244:32: sparse: sparse: cast to restricted __be32
   net/core/filter.c:1884:43: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted __wsum [usertype] diff @@     got unsigned long long [usertype] to @@
   net/core/filter.c:1884:43: sparse:     expected restricted __wsum [usertype] diff
   net/core/filter.c:1884:43: sparse:     got unsigned long long [usertype] to
   net/core/filter.c:1887:36: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted __be16 [usertype] old @@     got unsigned long long [usertype] from @@
   net/core/filter.c:1887:36: sparse:     expected restricted __be16 [usertype] old
   net/core/filter.c:1887:36: sparse:     got unsigned long long [usertype] from
   net/core/filter.c:1887:42: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected restricted __be16 [usertype] new @@     got unsigned long long [usertype] to @@
   net/core/filter.c:1887:42: sparse:     expected restricted __be16 [usertype] new
   net/core/filter.c:1887:42: sparse:     got unsigned long long [usertype] to
   net/core/filter.c:1890:36: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted __be32 [usertype] from @@     got unsigned long long [usertype] from @@
   net/core/filter.c:1890:36: sparse:     expected restricted __be32 [usertype] from
   net/core/filter.c:1890:36: sparse:     got unsigned long long [usertype] from
   net/core/filter.c:1890:42: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected restricted __be32 [usertype] to @@     got unsigned long long [usertype] to @@
   net/core/filter.c:1890:42: sparse:     expected restricted __be32 [usertype] to
   net/core/filter.c:1890:42: sparse:     got unsigned long long [usertype] to
   net/core/filter.c:1935:59: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected restricted __wsum [usertype] diff @@     got unsigned long long [usertype] to @@
   net/core/filter.c:1935:59: sparse:     expected restricted __wsum [usertype] diff
   net/core/filter.c:1935:59: sparse:     got unsigned long long [usertype] to
   net/core/filter.c:1938:52: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected restricted __be16 [usertype] from @@     got unsigned long long [usertype] from @@
   net/core/filter.c:1938:52: sparse:     expected restricted __be16 [usertype] from
   net/core/filter.c:1938:52: sparse:     got unsigned long long [usertype] from
   net/core/filter.c:1938:58: sparse: sparse: incorrect type in argument 4 (different base types) @@     expected restricted __be16 [usertype] to @@     got unsigned long long [usertype] to @@
   net/core/filter.c:1938:58: sparse:     expected restricted __be16 [usertype] to
   net/core/filter.c:1938:58: sparse:     got unsigned long long [usertype] to
   net/core/filter.c:1941:52: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected restricted __be32 [usertype] from @@     got unsigned long long [usertype] from @@
   net/core/filter.c:1941:52: sparse:     expected restricted __be32 [usertype] from
   net/core/filter.c:1941:52: sparse:     got unsigned long long [usertype] from
   net/core/filter.c:1941:58: sparse: sparse: incorrect type in argument 4 (different base types) @@     expected restricted __be32 [usertype] to @@     got unsigned long long [usertype] to @@
   net/core/filter.c:1941:58: sparse:     expected restricted __be32 [usertype] to
   net/core/filter.c:1941:58: sparse:     got unsigned long long [usertype] to
   net/core/filter.c:1987:28: sparse: sparse: incorrect type in return expression (different base types) @@     expected unsigned long long @@     got restricted __wsum @@
   net/core/filter.c:1987:28: sparse:     expected unsigned long long
   net/core/filter.c:1987:28: sparse:     got restricted __wsum
   net/core/filter.c:2009:35: sparse: sparse: incorrect type in return expression (different base types) @@     expected unsigned long long @@     got restricted __wsum [usertype] csum @@
   net/core/filter.c:2009:35: sparse:     expected unsigned long long
   net/core/filter.c:2009:35: sparse:     got restricted __wsum [usertype] csum
   net/core/filter.c:4730:17: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] spi @@     got restricted __be32 const [usertype] spi @@
   net/core/filter.c:4730:17: sparse:     expected unsigned int [usertype] spi
   net/core/filter.c:4730:17: sparse:     got restricted __be32 const [usertype] spi
   net/core/filter.c:4738:33: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] remote_ipv4 @@     got restricted __be32 const [usertype] a4 @@
   net/core/filter.c:4738:33: sparse:     expected unsigned int [usertype] remote_ipv4
   net/core/filter.c:4738:33: sparse:     got restricted __be32 const [usertype] a4

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux