On Thu, Jul 2, 2020 at 11:14 AM Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx> wrote: > > > + if (port->dev->mtu > ETH_DATA_LEN) { > > > + netdev_err(port->dev, "Jumbo frames are not supported by XDP, current MTU %d.\n", > > > + port->dev->mtu); > > > > ditto > > Here I agree and for every other netdev_err within mvpp2_xdp_setup(). > Nice idea, I'll add extack error reporting where possible. -- per aspera ad upstream