On Thu, Jul 2, 2020 at 1:26 PM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Wed, Jul 1, 2020 at 7:17 PM Daniel T. Lee <danieltimlee@xxxxxxxxx> wrote:
> >
> > From commit 646f02ffdd49 ("libbpf: Add BTF-defined map-in-map
> > support"), a way to define internal map in BTF-defined map has been
> > added.
> >
> > Instead of using previous 'inner_map_idx' definition, the structure to
> > be used for the inner map can be directly defined using array directive.
> >
> > __array(values, struct inner_map)
> >
> > This commit refactors map in map test program with libbpf by explicitly
> > defining inner map with BTF-defined format.
> >
> > Signed-off-by: Daniel T. Lee <danieltimlee@xxxxxxxxx>
> > ---
> > samples/bpf/Makefile | 2 +-
> > samples/bpf/test_map_in_map_kern.c | 85 +++++++++++++++---------------
> > samples/bpf/test_map_in_map_user.c | 53 +++++++++++++++++--
> > 3 files changed, 91 insertions(+), 49 deletions(-)
> >
>
> [...]
>
> > - if (load_bpf_file(filename)) {
> > - printf("%s", bpf_log_buf);
> > - return 1;
> > + prog = bpf_object__find_program_by_name(obj, "trace_sys_connect");
> > + if (libbpf_get_error(prog)) {
>
> still wrong, just `if (!prog)`
>
Oops, my bad.
Will fix right away.
Thanks for your time and effort for the review.
Daniel.
> > + printf("finding a prog in obj file failed\n");
> > + goto cleanup;
> > + }
> > +
>
> [...]
