Re: [PATCH bpf-next 0/3] Strip away modifiers from BPF skeleton global variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 1, 2020 at 8:02 AM Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
>
> On Tue, Jun 30, 2020 at 11:46 PM Andrii Nakryiko <andriin@xxxxxx> wrote:
> >
> > Fix bpftool logic of stripping away const/volatile modifiers for all global
> > variables during BPF skeleton generation. See patch #1 for details on when
> > existing logic breaks and why it's important. Support special .strip_mods=true
> > mode in btf_dump. Add selftests validating that everything works as expected.
>
> Why bother with the flag?

You mean btf_dump should do this always? That's a bit too invasive a
change, I don't like it.

> It looks like bugfix to me.

It can be considered a bug fix for bpftool's skeleton generation, but
it depends on non-trivial changes in libbpf, which are not bug fix per
se, so should probably better go through bpf-next.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux