On Mon, Jun 29, 2020 at 2:33 AM Tobias Klauser <tklauser@xxxxxxxxxx> wrote:
>
> Factor out code common for 32-bit and 64-bit x86 BPF JITs to bpf_jit.h
>
> Also follow other architectures and rename bpf_jit_comp.c to
> bpf_jit_comp64.c to be more explicit.
>
> Also adjust the file matching pattern in MAINTAINERS such that the
> common x86 files are included for both the 32-bit and 64-bit BPF JIT
> sections.
>
> Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>
> ---
> MAINTAINERS | 3 +-
> arch/x86/net/Makefile | 2 +-
> arch/x86/net/bpf_jit.h | 93 ++++++++++++
> arch/x86/net/bpf_jit_comp32.c | 135 ++++--------------
> .../net/{bpf_jit_comp.c => bpf_jit_comp64.c} | 84 +----------
> 5 files changed, 123 insertions(+), 194 deletions(-)
> create mode 100644 arch/x86/net/bpf_jit.h
> rename arch/x86/net/{bpf_jit_comp.c => bpf_jit_comp64.c} (96%)
I don't see any value in such refactoring.
Looks like code churn to me.
