On Thu, Jun 25, 2020 at 3:13 PM Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > Adding support to generate .BTF_ids section that will hold BTF > ID lists for verifier. > > Adding macros that will help to define lists of BTF ID values > placed in .BTF_ids section. They are initially filled with zeros > (during compilation) and resolved later during the linking phase > by resolve_btfids tool. > > Following defines list of one BTF ID value: > > BTF_ID_LIST(bpf_skb_output_btf_ids) > BTF_ID(struct, sk_buff) > > It also defines following variable to access the list: > > extern int bpf_skb_output_btf_ids[]; > > Suggested-by: Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx> > --- Looks good, with few nits below. Acked-by: Andrii Nakryiko <andriin@xxxxxx> > include/asm-generic/vmlinux.lds.h | 4 ++ > include/linux/btf_ids.h | 69 +++++++++++++++++++++++++++++++ > 2 files changed, 73 insertions(+) > create mode 100644 include/linux/btf_ids.h > [...] > diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h > new file mode 100644 > index 000000000000..f7f9dc4d9a9f > --- /dev/null > +++ b/include/linux/btf_ids.h > @@ -0,0 +1,69 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _LINUX_BTF_IDS_H > +#define _LINUX_BTF_IDS_H 1 this "1", is it necessary? I think it's always just `#define HEADER_GUARD`? > + > +#include <linux/compiler.h> /* for __PASTE */ > + [...] > +#define __BTF_ID_LIST(name) \ > +asm( \ > +".pushsection " BTF_IDS_SECTION ",\"a\"; \n" \ > +".local " #name "; \n" \ > +#name ":; \n" \ > +".popsection; \n"); \ > + > +#define BTF_ID_LIST(name) \ > +__BTF_ID_LIST(name) \ > +extern int name[]; nit: extern u32 (or __u32) perhaps? > + > +#endif > -- > 2.25.4 >
