Re: [PATCH 2/3] samples: bpf: cleanup pointer error check with libbpf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 26, 2020 at 1:18 AM Daniel T. Lee <danieltimlee@xxxxxxxxx> wrote:
>
> Libbpf has its own helper function to check for errors in the bpf
> data structure (pointer). And Some codes do not use this libbbpf
> helper function and check the pointer's error directly.
>
> This commit clean up the existing pointer error check logic with
> libbpf.
>
> Signed-off-by: Daniel T. Lee <danieltimlee@xxxxxxxxx>
> ---

This entire patch is wrong. bpf_object__find_program_by_name() returns
NULL if the program is not found, not an error code.

>  samples/bpf/sampleip_user.c    | 2 +-
>  samples/bpf/trace_event_user.c | 2 +-
>  samples/bpf/tracex1_user.c     | 2 +-
>  samples/bpf/tracex5_user.c     | 2 +-
>  samples/bpf/tracex7_user.c     | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
>

[...]



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux