Re: [PATCH v3 bpf-next 7/9] libbpf: add SEC name for xdp programs attached to CPUMAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 24, 2020 at 1:36 AM Jesper Dangaard Brouer
<brouer@xxxxxxxxxx> wrote:
>
> On Tue, 23 Jun 2020 22:49:02 -0700
> Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote:
>
> > On Tue, Jun 23, 2020 at 2:40 PM Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote:
> > >
> > > As for DEVMAP, support SEC("xdp_cpumap*") as a short cut for loading
>                                 ^^^^^^^^^^^
>
> Maybe update desc to include the "/" ?

+1

>
> > > the program with type BPF_PROG_TYPE_XDP and expected attach type
> > > BPF_XDP_CPUMAP.
> > >
> > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> > > ---
> >
> > Thanks!
> >
> > Acked-by: Andrii Nakryiko <andriin@xxxxxx>
>
> I like this extra "/".
>
> Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
>
> If we agree, I hope we can also adjust this for devmap in bpf-tree ?

Yes. Please.
It's not in an official release. There is time to adjust things.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux