On Tue, Jun 23, 2020 at 5:34 PM Andrii Nakryiko <andriin@xxxxxx> wrote:
>
> Similar message for map creation is extremely useful, so add similar for BPF
> programs.
'extremely useful' is quite subjective.
If we land this patch then everyone will be allowed to add pr_debug()
everywhere in libbpf with the same reasoning: "it's extremely useful pr_debug".
> Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>
> ---
> tools/lib/bpf/libbpf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 18461deb1b19..f24a90c86c58 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -5379,8 +5379,9 @@ load_program(struct bpf_program *prog, struct bpf_insn *insns, int insns_cnt,
> }
>
> ret = bpf_load_program_xattr(&load_attr, log_buf, log_buf_size);
> -
> if (ret >= 0) {
> + pr_debug("prog '%s' ('%s'): created successfully, fd=%d\n",
> + prog->name, prog->section_name, ret);
> if (log_buf && load_attr.log_level)
> pr_debug("verifier log:\n%s", log_buf);
> *pfd = ret;
> --
> 2.24.1
>
