On Tue, Jun 23, 2020 at 2:39 PM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote: > > Building bpftool yields the following complaint: > > pids.c: In function 'emit_obj_refs_json': > pids.c:175:80: warning: declaration of 'json_wtr' shadows a global declaration [-Wshadow] > 175 | void emit_obj_refs_json(struct obj_refs_table *table, __u32 id, json_writer_t *json_wtr) > | ~~~~~~~~~~~~~~~^~~~~~~~ > In file included from pids.c:11: > main.h:141:23: note: shadowed declaration is here > 141 | extern json_writer_t *json_wtr; > | ^~~~~~~~ > > Let's rename the variable. > > v2: > - Rename the variable instead of calling the global json_wtr directly. > > Signed-off-by: Quentin Monnet <quentin@xxxxxxxxxxxxx> > --- Thanks. Acked-by: Andrii Nakryiko <andriin@xxxxxx> [...]
