On Mon, Jun 22, 2020 at 10:44:56PM -0700, Andrii Nakryiko wrote:
> On Sun, Jun 21, 2020 at 7:34 AM Jakub Bogusz <qboosh@xxxxxxxxxxxxx> wrote:
> >
> > Hello,
> >
> > I noticed that _bpftool crashes when building kernel tools (5.7.x) for
> > 32-bit targets because in libbpf hashmap implementation hash_bits()
> > function returning numbers exceeding hashmap buckets capacity.
> >
> > Attached patch fixes this problem.
> >
>
> Thanks! But this was already fixed by Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> in 8ca8d4a84173 ("libbpf: Define __WORDSIZE if not available").
No, it's not:
This change worked around __WORDSIZE not always being available.
But the issue on (I)LP32 platforms is that 64-bit value is shifted by
(32-bits) instead of (64-bits).
(__SIZEOF_LONG__ * 8) is 32 on such architectures (i686, arm).
I used __SIZEOF_LONG_LONG__ to get proper bit shift both on (I)LP32 and
LP64 architectures.
Should I provide an updated patch to apply on top of acme change?
Regards,
--
Jakub Bogusz http://qboosh.pl/
