Re: [PATCH bpf-next] tools, bpftool: Correctly evaluate $(BUILD_BPF_SKELS) in Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2020-06-23 12:37 UTC+0200 ~ Tobias Klauser <tklauser@xxxxxxxxxx>
> Currently, if the clang-bpf-co-re feature is not available, the build
> fails with e.g.
> 
>   CC       prog.o
> prog.c:1462:10: fatal error: profiler.skel.h: No such file or directory
>  1462 | #include "profiler.skel.h"
>       |          ^~~~~~~~~~~~~~~~~
> 
> This is due to the fact that the BPFTOOL_WITHOUT_SKELETONS macro is not
> defined, despite BUILD_BPF_SKELS not being set. Fix this by correctly
> evaluating $(BUILD_BPF_SKELS) when deciding on whether to add
> -DBPFTOOL_WITHOUT_SKELETONS to CFLAGS.
> 
> Fixes: 05aca6da3b5a ("tools/bpftool: Generalize BPF skeleton support and generate vmlinux.h")
> Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>

Reviewed-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>

Thanks Tobias.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux