Re: [PATCH bpf-next 1/2] tools, bpftool: Define prog_type_name array only once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2020-06-22 17:05 UTC+0200 ~ Tobias Klauser <tklauser@xxxxxxxxxx>
> On 2020-06-22 at 16:26:17 +0200, Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote:
>> 2020-06-22 16:00 UTC+0200 ~ Tobias Klauser <tklauser@xxxxxxxxxx>
>>> Follow the same approach as for map_type_name. This leads to a slight
>>
>> map_type_name looks unchanged in this series, could you please check
>> your commit log?
> 
> Yes this patch intentionally shouldn't change map_type_name. The idea
> was to say "do the same thing for prog_type_name name as is already done
> for map_type_name". I can rephrase that to become more clear if you
> want.

Ok sorry, I thought you meant map_type_name had been moved to reduce the
size as well. I think I got confused by "Follow the same approach",
since map_type_name has always been in map.c, but it's both
prog_type_name and attach_type_name that were moved to main.h from their
original files some time ago (so not much to "follow" from map_type_name).

Anyway, minor confusion on my side, no need to respin just for that.
Thanks for the clarification.

Quentin



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux