Re: [PATCH bpf-next 10/13] bpf/selftests: move newer bpf_iter_* type redefining to a new header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 17, 2020 at 2:16 PM Yonghong Song <yhs@xxxxxx> wrote:
>
> Commit b9f4c01f3e0b ("selftest/bpf: Make bpf_iter selftest
> compilable against old vmlinux.h") and Commit dda18a5c0b75
> ("selftests/bpf: Convert bpf_iter_test_kern{3, 4}.c to define
> own bpf_iter_meta") redefined newly introduced types
> in bpf programs so the bpf program can still compile
> properly with old kernels although loading may fail.
>
> Since this patch set introduced new types and the same
> workaround is needed, so let us move the workaround
> to a separate header file so they do not clutter
> bpf programs.
>
> Signed-off-by: Yonghong Song <yhs@xxxxxx>
> ---

Thanks for the clean up!

Acked-by: Andrii Nakryiko <andriin@xxxxxx>

>  tools/testing/selftests/bpf/progs/bpf_iter.h  | 49 +++++++++++++++++++
>  .../selftests/bpf/progs/bpf_iter_bpf_map.c    | 18 +------
>  .../selftests/bpf/progs/bpf_iter_ipv6_route.c | 18 +------
>  .../selftests/bpf/progs/bpf_iter_netlink.c    | 18 +------
>  .../selftests/bpf/progs/bpf_iter_task.c       | 18 +------
>  .../selftests/bpf/progs/bpf_iter_task_file.c  | 20 +-------
>  .../selftests/bpf/progs/bpf_iter_test_kern3.c | 17 +------
>  .../selftests/bpf/progs/bpf_iter_test_kern4.c | 17 +------
>  .../bpf/progs/bpf_iter_test_kern_common.h     | 18 +------
>  9 files changed, 57 insertions(+), 136 deletions(-)
>  create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter.h
>

[...]



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux