On Sun, Jun 07, 2020 at 06:56:38AM -0500, Eric W. Biederman wrote: > ebiederm@xxxxxxxxxxxx (Eric W. Biederman) writes: > > > I have sympathy with your efforts but since the code is currently dead, > > and in need of work. I will write a good version of removing > > CONFIG_BPFILTER_UMH on top of -rc1, leaving CONFIG_BPFILTER. > > Of course when I just limit my code removal to code that depends upon > the user mode helper all that is left is a Kconfig entry and > include/uapi/linux/bpfilter.h. This bit you can actually remove. bpfilter didn't materialize. But 'elf in vmlinux' is useful. Please keep it. > I also noticed that the type of do_exeve_file is wrong. envp and argv > are not "void *", they should be "const char __user *const __user *__argv". Sounds like a trivial fix.