On Sun, May 31, 2020 at 1:31 AM Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> wrote: > > Make `bpf link show` aware of new link type, that is links attached to > netns. When listing netns-attached links, display netns inode number as its > identifier and link attach type. > > Sample session: > > # readlink /proc/self/ns/net > net:[4026532251] > # bpftool prog show > 357: flow_dissector tag a04f5eef06a7f555 gpl > loaded_at 2020-05-30T16:53:51+0200 uid 0 > xlated 16B jited 37B memlock 4096B > 358: flow_dissector tag a04f5eef06a7f555 gpl > loaded_at 2020-05-30T16:53:51+0200 uid 0 > xlated 16B jited 37B memlock 4096B > # bpftool link show > 108: netns prog 357 > netns_ino 4026532251 attach_type flow_dissector > # bpftool link -jp show > [{ > "id": 108, > "type": "netns", > "prog_id": 357, > "netns_ino": 4026532251, > "attach_type": "flow_dissector" > } > ] > > (... after netns is gone ...) > > # bpftool link show > 108: netns prog 357 > netns_ino 0 attach_type flow_dissector > # bpftool link -jp show > [{ > "id": 108, > "type": "netns", > "prog_id": 357, > "netns_ino": 0, > "attach_type": "flow_dissector" > } > ] > > Signed-off-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> > --- LGTM. Not sure if bpftool allows to filter progs/maps by type, but probably we should eventually add link type filtering ("show me only netns links")... Acked-by: Andrii Nakryiko <andriin@xxxxxx> > tools/bpf/bpftool/link.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > [...]