On Fri, May 29, 2020 at 3:07 PM David Ahern <dsahern@xxxxxxxxxx> wrote:
>
> Implementation of Daniel's proposal for allowing DEVMAP entries to be
> a device index, program fd pair.
>
> Programs are run after XDP_REDIRECT and have access to both Rx device
> and Tx device.
>
> v4
> - moved struct bpf_devmap_val from uapi to devmap.c, named the union
> and dropped the prefix from the elements - Jesper
> - fixed 2 bugs in selftests
Applied.
In patch 5 I had to fix:
/data/users/ast/net-next/tools/testing/selftests/bpf/prog_tests/xdp_devmap_attach.c:
In function ‘test_neg_xdp_devmap_helpers’:
/data/users/ast/net-next/tools/testing/selftests/bpf/test_progs.h:106:3:
warning: ‘duration’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
106 | fprintf(stdout, "%s:PASS:%s %d nsec\n", \
| ^~~~~~~
/data/users/ast/net-next/tools/testing/selftests/bpf/prog_tests/xdp_devmap_attach.c:79:8:
note: ‘duration’ was declared here
79 | __u32 duration;
and that selftest is imo too primitive.
It's only loading progs and not executing them.
Could you please add prog_test_run to it?
