On Thu, 28 May 2020 23:20:53 -0600
David Ahern <dsahern@xxxxxxxxxx> wrote:
> Add 'struct bpf_devmap_val' to the bpf uapi to formalize the
> expected values that can be passed in for a DEVMAP.
> Update devmap code to use the struct.
>
> Signed-off-by: David Ahern <dsahern@xxxxxxxxxx>
> ---
> include/uapi/linux/bpf.h | 5 +++++
> kernel/bpf/devmap.c | 40 +++++++++++++++++++---------------
> tools/include/uapi/linux/bpf.h | 5 +++++
> 3 files changed, 33 insertions(+), 17 deletions(-)
>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 54b93f8b49b8..42c884dfbad9 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -3625,6 +3625,11 @@ struct xdp_md {
> __u32 rx_queue_index; /* rxq->queue_index */
> };
>
> +/* DEVMAP values */
> +struct bpf_devmap_val {
> + __u32 ifindex; /* device index */
> +};
We do need this struct bpf_devmap_val, but I think it is wrong to make this UAPI.
A BPF-prog can get this via: #include "vmlinux.h"
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
