Re: [PATCH bpf-next] tools: bpftool: clean subcommand help messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/23/20 3:07 AM, Quentin Monnet wrote:
This is a clean-up for the formatting of the do_help functions for
bpftool's subcommands. The following fixes are included:

- Do not use argv[-2] for "iter" help message, as the help is shown by
   default if no "iter" action is selected, resulting in messages looking
   like "./bpftool bpftool pin...".

- Do not print unused HELP_SPEC_PROGRAM in help message for "bpftool
   link".

- Andrii used argument indexing to avoid having multiple occurrences of
   bin_name and argv[-2] in the fprintf() for the help message, for
   "bpftool gen" and "bpftool link". Let's reuse this for all other help
   functions. We can remove up to thirty arguments for the "bpftool map"
   help message.

- Harmonise all functions, e.g. use ending quotes-comma on a separate
   line.

Signed-off-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>

Applied, thanks!



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux