On Thu, May 21, 2020 at 3:21 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Thu, May 21, 2020 at 1:07 PM John Fastabend <john.fastabend@xxxxxxxxx> wrote: > > > > This series adds logic to the verifier to handle the case where a > > pointer is known to be non-null but then the verifier encountesr a > > instruction, such as 'if ptr == 0 goto X' or 'if ptr != 0 goto X', > > where the pointer is compared against 0. Because the verifier tracks > > if a pointer may be null in many cases we can improve the branch > > tracking by following the case known to be true. > > > > The first patch adds the verifier logic and patches 2-4 add the > > test cases. > > > > v1->v2: fix verifier logic to return -1 indicating both paths must > > still be walked if value is not zero. Move mark_precision skip for > > this case into caller of mark_precision to ensure mark_precision can > > still catch other misuses. And add PTR_TYPE_BTF_ID to our list of > > supported types. Finally add one more test to catch the value not > > equal zero case. Thanks to Andrii for original review. > > > > Also fixed up commit messages hopefully its better now. > > > > Yeah, much better, thanks! Few typos don't count ;) > > For the series: > > Acked-by: Andrii Nakryiko <andriin@xxxxxx> Applied. Thanks a lot everyone.
