Em Thu, May 21, 2020 at 01:43:25PM +0200, Jiri Olsa escreveu: > On Wed, May 20, 2020 at 11:20:04AM -0700, Ian Rogers wrote: > > SNIP > > > There are 5 out of 12 metric groups where no events are shared, such > > as Power, however, disabling grouping of events always reduces the > > number of events. > > > > The result for Memory_BW needs explanation: > > > > Metric group: Memory_BW > > - No merging (old default, now --metric-no-merge): 9 > > - Merging over metrics (new default) : 5 > > - No event groups and merging (--metric-no-group): 11 > > > > Both with and without merging the groups fail to be set up and so the > > event counts here are for broken metrics. The --metric-no-group number > > is accurate as all the events are scheduled. Ideally a constraint > > would be added for these metrics in the json code to avoid grouping. > > > > v2. rebases on kernel/git/acme/linux.git branch tmp.perf/core, fixes a > > missing comma with metric lists (reported-by Jiri Olsa > > <jolsa@xxxxxxxxxx>) and adds early returns to metricgroup__add_metric > > (suggested-by Jiri Olsa). > > Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx> Applied and pushed to tmp.perf/core, will move to perf/core as soon as testing finishes, - Arnaldo
