在 2020/5/20 15:05, Jiri Olsa 写道:
On Wed, May 20, 2020 at 11:32:16AM +0800, Wang ShaoBo wrote:key_scan_pos is a pointer for getting scan position in bpf__obj_config_map() for each BPF map configuration term, but it's misused when error not happened. Fixes: 066dacbf2a32 ("perf bpf: Add API to set values to map entries in a bpf object") Signed-off-by: Wang ShaoBo <bobo.shaobowang@xxxxxxxxxx> --- tools/perf/util/bpf-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/bpf-loader.c b/tools/perf/util/bpf-loader.c index 10c187b8b8ea..460056bc072c 100644 --- a/tools/perf/util/bpf-loader.c +++ b/tools/perf/util/bpf-loader.c @@ -1225,7 +1225,7 @@ bpf__obj_config_map(struct bpf_object *obj, out: free(map_name); if (!err) - key_scan_pos += strlen(map_opt); + *key_scan_pos += strlen(map_opt);seems good, was there something failing because of this? Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx> thanks, jirka
I found this problem when i checked this code, I think it is an implicit question, but if we delete the two line, the problem also no longer exists. thanks, Wang ShaoBo
