On Wed, May 13, 2020 at 05:58:35PM +0800, Hangbin Liu wrote: > > Thanks test bot catch the issue. > On Wed, May 13, 2020 at 03:44:18PM +0800, kernel test robot wrote: > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-7): > > > > commit: 77bb53cb094828a31cd3c5b402899810f63073c1 ("selftests/bpf: Fix perf_buffer test on systems w/ offline CPUs") > > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y > > The author for this commit is Andrii(cc'd). > > Mine is f1c3656c6d9c ("selftests/bpf: Skip perf hw events test if the setup disabled it") > > prog_tests/stacktrace_build_id_nmi.c:55:3: error: label ‘cleanup’ used but not defined > > goto cleanup; > > ^~~~ > > Hi Greg, we are missing a depend commit > dde53c1b763b ("selftests/bpf: Convert few more selftest to skeletons"). > > So either we need backport this patch, or if you like, we can also fix it by > changing 'goto cleanup;' to 'goto close_prog;'. So which one do you prefer? I don't know, I have no context here at all, sorry. What stable kernel tree is failing, what patch needs to be changed, what patch caused this, and so on... confused, greg k-h