On 05/06, Martin KaFai Lau wrote:
On Wed, May 06, 2020 at 03:32:08PM -0700, Stanislav Fomichev wrote: > 1. Move pkt_v4 and pkt_v6 into network_helpers and adjust the users. > 2. Copy-paste spin_lock_thread into two tests that use it. Instead of copying it into two tests, can spin_lock_thread be moved to network-helpers.c?
spin_lock_thread doesn't look like something that can be reused by other networking tests and looks very specific to prog_tests/spinlock.c and prog_tests/map_lock.c. It might be better with the copy-paste now because that thread definition is closer to the place that uses it. I don't feel strongly about it and can put it into network_helpers. Let me know if you prefer it that way.
