Re: [PATCH bpf-next 2/3] selftests/bpf: Test that lookup on SOCKMAP/SOCKHASH is allowed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Sitnicki wrote:
> On Wed, Apr 29, 2020 at 09:23 PM CEST, John Fastabend wrote:
> > Jakub Sitnicki wrote:
> >> Now that bpf_map_lookup_elem() is white-listed for SOCKMAP/SOCKHASH,
> >> replace the tests which check that verifier prevents lookup on these map
> >> types with ones that ensure that lookup operation is permitted, but only
> >> with a release of acquired socket reference.
> >> 
> >> Signed-off-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
> >> ---
> >
> > For completeness would be nice to add a test passing this into
> > sk_select_reuseport to cover that case as well. Could come as
> > a follow up patch imo.
> 
> Is this what you had in mind?

Yes thanks!

> 
> https://lore.kernel.org/bpf/20200430104738.494180-1-jakub@xxxxxxxxxxxxxx/
> 
> Thanks for reviewing the series.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux