On Thu, Apr 30, 2020 at 12:16 AM Song Liu <songliubraving@xxxxxx> wrote:
>
> Add test for BPF_ENABLE_STATS, which should enable run_time_ns stats.
>
> ~/selftests/bpf# ./test_progs -t enable_stats -v
> test_enable_stats:PASS:skel_open_and_load 0 nsec
> test_enable_stats:PASS:get_stats_fd 0 nsec
> test_enable_stats:PASS:attach_raw_tp 0 nsec
> test_enable_stats:PASS:get_prog_info 0 nsec
> test_enable_stats:PASS:check_stats_enabled 0 nsec
> test_enable_stats:PASS:check_run_cnt_valid 0 nsec
> Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED
>
> Signed-off-by: Song Liu <songliubraving@xxxxxx>
> ---
LGTM.
Acked-by: Andrii Nakryiko <andriin@xxxxxx>
> .../selftests/bpf/prog_tests/enable_stats.c | 45 +++++++++++++++++++
> .../selftests/bpf/progs/test_enable_stats.c | 18 ++++++++
> 2 files changed, 63 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/enable_stats.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_enable_stats.c
>
[...]
> + stats_fd = bpf_enable_stats(BPF_STATS_RUN_TIME);
> + if (CHECK(stats_fd < 0, "get_stats_fd", "failed %d\n", errno)) {
> + test_enable_stats__destroy(skel);
> + return;
> + }
> +
> + err = test_enable_stats__attach(skel);
> + if (CHECK(err, "attach_raw_tp", "err %d\n", err))
> + goto cleanup;
> +
> + test_enable_stats__detach(skel);
It's a bit subtle that we rely on detach (which does close()) to
trigger attached program :) But it works!
> +
> + prog_fd = bpf_program__fd(skel->progs.test_enable_stats);
> + memset(&info, 0, info_len);
> + err = bpf_obj_get_info_by_fd(prog_fd, &info, &info_len);
> + if (CHECK(err, "get_prog_info",
> + "failed to get bpf_prog_info for fd %d\n", prog_fd))
> + goto cleanup;
> + if (CHECK(info.run_time_ns == 0, "check_stats_enabled",
> + "failed to enable run_time_ns stats\n"))
> + goto cleanup;
> +
> + CHECK(info.run_cnt != skel->bss->count, "check_run_cnt_valid",
> + "invalid run_cnt stats\n");
> +
[...]
