> -----Original Message----- > From: Jesper Dangaard Brouer <brouer@xxxxxxxxxx> > Sent: Thursday, April 30, 2020 7:21 AM > To: sameehj@xxxxxxxxxx > Cc: Wei Liu <wei.liu@xxxxxxxxxx>; KY Srinivasan <kys@xxxxxxxxxxxxx>; > Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger > <sthemmin@xxxxxxxxxxxxx>; Jesper Dangaard Brouer > <brouer@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; > zorik@xxxxxxxxxx; akiyano@xxxxxxxxxx; gtzalik@xxxxxxxxxx; Toke > Høiland-Jørgensen <toke@xxxxxxxxxx>; Daniel Borkmann > <borkmann@xxxxxxxxxxxxx>; Alexei Starovoitov > <alexei.starovoitov@xxxxxxxxx>; John Fastabend > <john.fastabend@xxxxxxxxx>; Alexander Duyck > <alexander.duyck@xxxxxxxxx>; Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>; > David Ahern <dsahern@xxxxxxxxx>; Willem de Bruijn > <willemdebruijn.kernel@xxxxxxxxx>; Ilias Apalodimas > <ilias.apalodimas@xxxxxxxxxx>; Lorenzo Bianconi <lorenzo@xxxxxxxxxx>; > Saeed Mahameed <saeedm@xxxxxxxxxxxx>; > steffen.klassert@xxxxxxxxxxx > Subject: [PATCH net-next v2 12/33] hv_netvsc: add XDP frame size to driver > > The hyperv NIC drivers XDP implementation is rather disappointing as it will > be a slowdown to enable XDP on this driver, given it will allocate a new page > for each packet and copy over the payload, before invoking the XDP BPF- > prog. This needs correction. As I said previously -- This statement is not accurate -- The data path of netvsc driver does memory allocation and copy even without XDP, so it's not "a slowdown to enable XDP". Thanks, - Haiyang