On Mon, Apr 27, 2020 at 6:44 PM carlos antonio neira bustos <cneirabustos@xxxxxxxxx> wrote: > > Hi, > > I’m sorry I’ll do the work needed this week. > Thanks for the heads up. > > Bests. No worries, thanks! > > > El El lun, 27 de abr. de 2020 a la(s) 21:40, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> escribió: >> >> On Fri, Mar 13, 2020 at 5:48 AM Carlos Antonio Neira Bustos >> <cneirabustos@xxxxxxxxx> wrote: >> > >> > On Thu, Mar 12, 2020 at 05:45:09PM -0700, Alexei Starovoitov wrote: >> > > On Wed, Mar 4, 2020 at 12:42 PM Carlos Neira <cneirabustos@xxxxxxxxx> wrote: >> > > > >> > > > Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's >> > > > scripts but this helper returns the pid as seen by the root namespace which is >> > > > fine when a bcc script is not executed inside a container. >> > > > When the process of interest is inside a container, pid filtering will not work >> > > > if bpf_get_current_pid_tgid() is used. >> > > > This helper addresses this limitation returning the pid as it's seen by the current >> > > > namespace where the script is executing. >> > > > >> > > > In the future different pid_ns files may belong to different devices, according to the >> > > > discussion between Eric Biederman and Yonghong in 2017 Linux plumbers conference. >> > > > To address that situation the helper requires inum and dev_t from /proc/self/ns/pid. >> > > > This helper has the same use cases as bpf_get_current_pid_tgid() as it can be >> > > > used to do pid filtering even inside a container. >> > > >> > > Applied. Thanks. >> > > There was one spurious trailing whitespace that I fixed in patch 3 >> > > and missing .gitignore update for test_current_pid_tgid_new_ns. >> > > Could you please follow up with another patch to fold >> > > test_current_pid_tgid_new_ns into test_progs. >> > > I'd really like to consolidate all tests into single binary. >> > >> > Thank you very much Alexei, >> > I'll start working on the follow up patch to add test_current_pid_tgid_new_ns into test_progs. >> > >> >> Hey Carlos, >> >> Do you still plan to fold test_current_pid_tgid_new_ns into test_progs? >> >> > Bests
